Fix UnicodeDecodeError in Triton depthwise conv template#176484
Fix UnicodeDecodeError in Triton depthwise conv template#176484kevinngo0407 wants to merge 1 commit intopytorch:mainfrom
Conversation
Summary: Our test is failing with a `UnicodeDecodeError` during Triton template loading. The cause was a non-ASCII em-dash character (`–`, U+2013) in a comment on line 2 of `triton_depthwise_conv.py.jinja`. When the Triton template engine reads the file, it uses ASCII decoding, which cannot handle multi-byte UTF-8 characters. The fix replaces the em-dash with a standard ASCII hyphen (`-`). Test Plan: Ran cogwheel test Reviewed By: chevalierNoir, kqfu Differential Revision: D95211429
|
This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @kevinngo0407, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team. |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/176484
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a8be302 with merge base e77361a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
This PR needs a
|
|
@kevinngo0407 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95211429. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary:
Our test is failing with a
UnicodeDecodeErrorduring Triton template loading. The cause was a non-ASCII em-dash character (–, U+2013) in a comment on line 2 oftriton_depthwise_conv.py.jinja. When the Triton template engine reads the file, it uses ASCII decoding, which cannot handle multi-byte UTF-8 characters.The fix replaces the em-dash with a standard ASCII hyphen (
-).Test Plan: Ran cogwheel test
Reviewed By: chevalierNoir, kqfu
Differential Revision: D95211429
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @jataylo