[CD][CUDA13][PTXAS] Remove ptxas bundle from PyTorch cu13 Binary#174716
[CD][CUDA13][PTXAS] Remove ptxas bundle from PyTorch cu13 Binary#174716nWEIdia wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/174716
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 7 Cancelled JobsAs of commit 55f4526 with merge base 1aa5e36 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
Two follow-ups needed:
|
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
4028921 to
84e3531
Compare
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
84e3531 to
1935092
Compare
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
1935092 to
786e656
Compare
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
786e656 to
8abcbd1
Compare
|
The follow up question is: ""ptxas": "12.9.86" |
|
Previously without bundled ptxas, dgx spark or Thor users do not have a convenient way of getting ptxas (since triton did not ship a cuda 13.1 ptxas as it current does), so the bundled ptxas -- for people who know, would be a last resort to solve the problem without installing CTK. Now, even when the PyTorch code (compile_task.py) only uses |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
12.9), which fixes pytorch#163801 permanently. Reverting the bundling of ptxas, as even without ctk, users could get it from simply pip installing triton.
|
Successfully rebased |
8abcbd1 to
55f4526
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 7 jobs have failed, first few of them are: linux-s390x-binary-manywheel / manywheel-py3_13-cpu-s390x-build / build, linux-s390x-binary-manywheel / manywheel-py3_11-cpu-s390x-build / build, linux-s390x-binary-manywheel / manywheel-py3_10-cpu-s390x-build / build, linux-s390x-binary-manywheel / manywheel-py3_13t-cpu-s390x-build / build, linux-s390x-binary-manywheel / manywheel-py3_12-cpu-s390x-build / build Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 7 jobs have failed, first few of them are: linux-s390x-binary-manywheel / manywheel-py3_13-cpu-s390x-build / build, linux-s390x-binary-manywheel / manywheel-py3_11-cpu-s390x-build / build, linux-s390x-binary-manywheel / manywheel-py3_10-cpu-s390x-build / build, linux-s390x-binary-manywheel / manywheel-py3_13t-cpu-s390x-build / build, linux-s390x-binary-manywheel / manywheel-py3_12-cpu-s390x-build / build Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 7 checks: linux-s390x-binary-manywheel / manywheel-py3_13-cpu-s390x-build / build, linux-s390x-binary-manywheel / manywheel-py3_11-cpu-s390x-build / build, linux-s390x-binary-manywheel / manywheel-py3_10-cpu-s390x-build / build, linux-s390x-binary-manywheel / manywheel-py3_13t-cpu-s390x-build / build, linux-s390x-binary-manywheel / manywheel-py3_12-cpu-s390x-build / build, linux-s390x-binary-manywheel / manywheel-py3_14t-cpu-s390x-build / build, linux-s390x-binary-manywheel / manywheel-py3_14-cpu-s390x-test / test Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
The ptxas bundling was introduced in #163988 to workaround issues users may face due to #163801
Fortunately, on the triton upstream side, triton-lang/triton@884fdae finally landed, which is means #163801 is permanently fixed.
In addition, pytorch's triton commit pin has been updated via #178821
We can now roll back #163801 .
In between, we unified the arm sbsa build with x86, so revert won't work. Manually reverting the export.
Test plan: download and check the binary size to confirm 1) ptxas is gone from both x86 and sbsa (even though I only added to sbsa cu13 initially) 2) unit test that ran on #163988 should still pass.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @jataylo @eqy @ptrblck @tinglvv @malfet @atalman