[C++ API] Rename BatchNorm running_variance to running_var#17371
Closed
yf225 wants to merge 1 commit intopytorch:masterfrom
Closed
[C++ API] Rename BatchNorm running_variance to running_var#17371yf225 wants to merge 1 commit intopytorch:masterfrom
yf225 wants to merge 1 commit intopytorch:masterfrom
Conversation
soumith
approved these changes
Feb 21, 2019
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@yf225 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is a mismatch in naming between Python BatchNorm
running_varand C++ BatchNormrunning_variance, which causes JIT model parameters loading to fail (pytorch/vision#728 (comment)):Renaming C++ BatchNorm
running_variancetorunning_varshould fix this problem.This is a BC-breaking change, but it should be easy for end user to rename
running_variancetorunning_varin their call sites.