[MPS] Remove error-checking sync point from MaxUnpool#172111
Merged
malfet merged 1 commit intorelease/2.10from Jan 9, 2026
Merged
[MPS] Remove error-checking sync point from MaxUnpool#172111malfet merged 1 commit intorelease/2.10from
malfet merged 1 commit intorelease/2.10from
Conversation
Introduced by #163036, that I should have rejected, but ship have sailed Also, delete unnecessary `test_max_unpool_invalid_indices` as those checks are already covered by `test_MaxUnpool_index_errors` , but they were skipped in the past as test is marked slow (though it should have been marked as such only for CUDA) Pull Request resolved: #172046 Approved by: https://github.com/manuelcandales ghstack dependencies: #172051, #172052 (cherry picked from commit 9469ce4)
This was referenced Jan 9, 2026
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/172111
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 11 PendingAs of commit a4d1607 with merge base 76b8fda ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Introduced by #163036, that I should have rejected, but ship have sailed
Also, delete unnecessary
test_max_unpool_invalid_indicesas those checks are already covered bytest_MaxUnpool_index_errors, but they were skipped in the past as test is marked slow (though it should have been marked as such only for CUDA)