Allow structseq to be input of operators where tuple is expected#17208
Closed
zasdfgbnm wants to merge 21 commits intopytorch:masterfrom
Closed
Allow structseq to be input of operators where tuple is expected#17208zasdfgbnm wants to merge 21 commits intopytorch:masterfrom
zasdfgbnm wants to merge 21 commits intopytorch:masterfrom
Conversation
…dtuple-printing
commit a808b39 Author: Xiang Gao <qasdfgtyuiop@gmail.com> Date: Sat Feb 16 17:09:20 2019 -0500 fix namespace commit 00ab07d Author: Xiang Gao <qasdfgtyuiop@gmail.com> Date: Sat Feb 16 15:52:27 2019 -0500 more cleanup py2-py3 logic commit b939afb Author: Xiang Gao <qasdfgtyuiop@gmail.com> Date: Sat Feb 16 15:25:53 2019 -0500 cleanup py2-py3 logic
Collaborator
Author
Contributor
|
Manual refcounting makes me nervous. This will need a close code review. |
Contributor
apaszke
reviewed
Feb 23, 2019
Collaborator
Author
|
@ezyang @apaszke @VitalyFedyunin Let's work on #17136 first :). This PR is built upon #17136 . |
Contributor
|
Merge most recent master into it please. |
VitalyFedyunin
approved these changes
Mar 1, 2019
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@pytorchbot retest this please |
Collaborator
Author
|
@pytorchbot rebase this please |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@VitalyFedyunin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the following code gives an error on python 2 because
retis a structseq which is not a tupleThis PR modify tuple check in python arg parser to allow structseq to be input of operators where tuple is expected, which would make the above code work.
Depend on: #17136
Partially fixes: #16813