[codemod][lowrisk] Remove unused exception parameter from caffe2/torch/csrc/Storage.cpp#168184
Closed
r-barnes wants to merge 1 commit intopytorch:mainfrom
Closed
[codemod][lowrisk] Remove unused exception parameter from caffe2/torch/csrc/Storage.cpp#168184r-barnes wants to merge 1 commit intopytorch:mainfrom
r-barnes wants to merge 1 commit intopytorch:mainfrom
Conversation
…h/csrc/Storage.cpp
Summary:
`-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it.
This:
```
try {
...
} catch (exception& e) {
// no use of e
}
```
should instead be written as
```
} catch (exception&) {
```
If the code compiles, this is safe to land.
Test Plan: Sandcastle
Differential Revision: D87467930
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/168184
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0825e23 with merge base 607e2e7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
approved these changes
Nov 19, 2025
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
-Wunused-exception-parameterhas identified an unused exception parameter. This diff removes it.This:
should instead be written as
If the code compiles, this is safe to land.
Test Plan: Sandcastle
Differential Revision: D87467930