[export] Enable context manager returns for dynamo graph capture.#168102
Closed
[export] Enable context manager returns for dynamo graph capture.#168102
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/168102
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit d934885 with merge base c8d790b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Summary: This adds the ability to trace through the code which has context manager enabled and returned in a user callable. Since we rely on side effects to return user defined variables, we cannot disable side effects by default anymore in the short term. So we decide to leave side effect config up to the caller side of dynamo_graph_capture_for_export, and still disable it for torch.export by default. In the short term we will just assume dynamo_graph_capture_for_export is a low level API and it's user responsibility to control side effect options. Test Plan: CI Reviewers: Subscribers: Tasks: Tags:
f13ed2d to
d934885
Compare
tugsbayasgalan
approved these changes
Nov 19, 2025
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This adds the ability to trace through the code which has context manager enabled
and returned in a user callable.
Since we rely on side effects to return user defined variables, we cannot disable
side effects by default anymore in the short term. So we decide to leave
side effect config up to the caller side of dynamo_graph_capture_for_export,
and still disable it for torch.export by default. In the short term we will
just assume dynamo_graph_capture_for_export is a low level API and it's user
responsibility to control side effect options.
Test Plan:
CI
Reviewers:
Subscribers:
Tasks:
Tags:
Fixes #ISSUE_NUMBER
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela