[DLPack] Minor change on DLConvertor naming#166325
Closed
Kathryn-cat wants to merge 1 commit intopytorch:mainfrom
Closed
[DLPack] Minor change on DLConvertor naming#166325Kathryn-cat wants to merge 1 commit intopytorch:mainfrom
Kathryn-cat wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166325
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 062535c with merge base 058782c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
@pytorchbot label "topic: not user facing" label "module: dlpack" |
|
Didn't find following labels among repository labels: label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces minor changes to DLConvertor function and naming.
getATenDeviceis changed todlDeviceToTorchDeviceand removed being exposed as static function, in order to be symmetric withtorchDeviceToDLDevice.toDLPackNonOwningis introduced to convert torch tensor to a non-owning DLPack tensor.