Skip to content

[CUDA][Grouped Gemm] remove xFail on Group GEMM tests after fallback was added#165378

Closed
eqy wants to merge 2 commits intopytorch:mainfrom
eqy:removegroupgemmxfail
Closed

[CUDA][Grouped Gemm] remove xFail on Group GEMM tests after fallback was added#165378
eqy wants to merge 2 commits intopytorch:mainfrom
eqy:removegroupgemmxfail

Conversation

@eqy
Copy link
Collaborator

@eqy eqy commented Oct 13, 2025 •
edited by pytorch-bot bot
Loading

#162059 means we get unexpected successes now on e.g., SM 12.0

cc @ptrblck @msaroufim @jerryzh168

@eqy eqy added module: cuda Related to torch.cuda, and CUDA support in general open source topic: not user facing topic category matrix multiplication labels Oct 13, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 13, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165378

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (6 Unrelated Failures)

As of commit 1f6d956 with merge base 23c55c5 (image):

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/b200 ciflow/h100 ciflow/rocm Trigger "default" config CI on ROCm labels Oct 20, 2025
@eqy
Copy link
Collaborator Author

eqy commented Oct 20, 2025

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 20, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 20, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 20, 2025

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@eqy
Copy link
Collaborator Author

eqy commented Oct 21, 2025

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 21, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 21, 2025

Successfully rebased removegroupgemmxfail onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout removegroupgemmxfail && git pull --rebase)

@eqy
Copy link
Collaborator Author

eqy commented Oct 24, 2025

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 24, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees

No one assigned

Labels

ciflow/b200 ciflow/h100 ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request matrix multiplication Merged module: cuda Related to torch.cuda, and CUDA support in general open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eqy @pytorchmergebot @Skylion007