[Code Clean] Clean asserts in torch/ao/quantization/experimental/* and torch/ao/quantization/pt2e/*#165317
[Code Clean] Clean asserts in torch/ao/quantization/experimental/* and torch/ao/quantization/pt2e/*#165317zhudada0120 wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165317
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit 8ddb086 with merge base b4fd471 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "topic: not user facing" |
|
Hi, @albanD, I've noticed that a problematic commit was accidentally included in this PR. I'll fix it tomorrow. Sorry for the confusion and thank you for your patience! |
a57830a to
da40510
Compare
|
Hi, @albanD, The unrelated commit has been cleaned up, PTAL, thanks |
cb70266 to
719b97f
Compare
| ) | ||
| if quant_min > quant_max: | ||
| raise AssertionError( | ||
| "quant_min must be less than or equal to quant_max" |
There was a problem hiding this comment.
For these, it would be great to print the actual values.
There was a problem hiding this comment.
I've updated the error message to include the actual values. PTAL, thanks.
fbf5638 to
8ddb086
Compare
|
@pytorchbot remove labels module: cpu, module: dynamo, module: inductor, oncall: distributed, release notes: distributed (checkpoint), release notes: inductor (aoti) |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot --help |
PyTorchBot HelpMergeRevertRebaseLabelDr CIcherry-pick |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Replace assert statements with explicit if/raise patterns in:
fix partialy #164878