Skip to content

Fix invalid f-strings#164112

Closed
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:ruf027
Closed

Fix invalid f-strings#164112
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:ruf027

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Sep 29, 2025 •
edited
Loading

@cyyever cyyever requested a review from zou3519 as a code owner September 29, 2025 05:52
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 29, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164112

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9503d75 with merge base b9854c9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor module: dynamo oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category labels Sep 29, 2025
@cyyever
Fix f-strings
9503d75 
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
@cyyever cyyever changed the title Ruf027 Fix invalid f-strings Sep 29, 2025
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 29, 2025
@Skylion007
Copy link
Collaborator

Skylion007 commented Sep 29, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 29, 2025
@Skylion007 Skylion007 added release notes: python_frontend python frontend release notes category and removed ciflow/trunk Trigger trunk jobs on your pull request labels Sep 29, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 29, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 29, 2025

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@cyyever
Copy link
Collaborator Author

cyyever commented Sep 30, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 30, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 30, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever
Copy link
Collaborator Author

cyyever commented Sep 30, 2025

@pytorchbot merge -f "Pending ROCM, otherwise the CI is green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 30, 2025

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 30, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the ruf027 branch September 30, 2025 04:20
@justinchuby
Copy link
Collaborator

justinchuby commented Oct 1, 2025

Is it possible to enable the rule in pyproject ?

@cyyever
Copy link
Collaborator Author

cyyever commented Oct 1, 2025

@justinchuby It relies on ruff --preview, I have to fix other warnings before enabling it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@mlazos mlazos mlazos approved these changes

@zou3519 zou3519 Awaiting requested review from zou3519 zou3519 is a code owner

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: distributed (c10d) release notes category release notes: python_frontend python frontend release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cyyever @Skylion007 @pytorchmergebot @justinchuby @mlazos @soulitzer @pytorchbot