Skip to content

[inductor] Small refactor of CachingAutotuner#162406

Closed
kundaMwiza wants to merge 3 commits intopytorch:mainfrom
graphcore:mwizak/refactor-caching-autotuner
Closed

[inductor] Small refactor of CachingAutotuner#162406
kundaMwiza wants to merge 3 commits intopytorch:mainfrom
graphcore:mwizak/refactor-caching-autotuner

Conversation

@kundaMwiza
Copy link
Collaborator

@kundaMwiza kundaMwiza commented Sep 8, 2025

This is a simple refactor that just moves some logic in _precompile_config to two new functions for separation of concerns. This will allow subclasses e.g. out of tree to configure options and metadata for triton.compile.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162406

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7835b6c with merge base 4cf2900 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kundaMwiza
Copy link
Collaborator Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 8, 2025
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 9, 2025
@kundaMwiza
Copy link
Collaborator Author

@exclamaforte @eellison Can I please get a review of this small PR when you're free? Thanks

@kundaMwiza kundaMwiza force-pushed the mwizak/refactor-caching-autotuner branch from a6563ff to cf4b1e2 Compare September 22, 2025 09:38
@kundaMwiza kundaMwiza force-pushed the mwizak/refactor-caching-autotuner branch from cf4b1e2 to 232fb00 Compare September 24, 2025 15:04
@kundaMwiza kundaMwiza changed the title [inductor] small refactor of CachingAutotuner [inductor] Small refactor of CachingAutotuner Sep 24, 2025
@kundaMwiza
Copy link
Collaborator Author

@exclamaforte @eellison bump

Copy link
Contributor

@exclamaforte exclamaforte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, lgtm

@kundaMwiza
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 29, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@kundaMwiza
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

1 similar comment
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants