Skip to content

[OpenReg] Add AMP Integration guide for accelerators#162050

Closed
zeshengzong wants to merge 1 commit intopytorch:mainfrom
zeshengzong:opt/openreg/amp
Closed

[OpenReg] Add AMP Integration guide for accelerators#162050
zeshengzong wants to merge 1 commit intopytorch:mainfrom
zeshengzong:opt/openreg/amp

Conversation

@zeshengzong
Copy link
Contributor

@zeshengzong zeshengzong commented Sep 3, 2025

Fix part of #158917

Add AMP integration document and OpenReg code as example to explain steps of integration.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162050

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 71272a4 with merge base bbf8aa4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 3, 2025
@zeshengzong zeshengzong changed the title [OpenReg] Add AMP backend implementation [WIP][OpenReg] Add AMP backend implementation Sep 3, 2025
@zeshengzong zeshengzong changed the title [WIP][OpenReg] Add AMP backend implementation Add AMP Integration guide for accelerators Sep 8, 2025
@zeshengzong zeshengzong marked this pull request as ready for review September 8, 2025 09:24
@zeshengzong zeshengzong changed the title Add AMP Integration guide for accelerators [OpenReg] Add AMP Integration guide for accelerators Sep 8, 2025
@fffrog
Copy link
Collaborator

fffrog commented Sep 12, 2025

Thank you for contributing to AMP.

Could you please update this README.md and add something related to AMP?

@fffrog fffrog marked this pull request as draft September 12, 2025 09:10
@fffrog
Copy link
Collaborator

fffrog commented Sep 12, 2025

Please follow those command mentioned below to make html locally.

pushd docs
pip3 install -r requirements.txt
make html

python -m http.server -d build/html 4000

Then you can see the rendering effect through the browser.

@soulitzer soulitzer requested a review from albanD September 12, 2025 12:40
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 12, 2025
**Changes**:
- Add amp features for OpenReg
- Add amp docs to accelerator integration

Co-authored-by: FFFrog <ljw1101.vip@gmail.com>
Co-authored-by: zeshengzong <zesheng.zong@outlook.com>
@fffrog fffrog marked this pull request as ready for review September 26, 2025 07:51
@fffrog
Copy link
Collaborator

fffrog commented Sep 26, 2025

Hey @albanD , please help to take a look at this. Thank you.

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Thank you!

@zeshengzong
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 30, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants