Skip to content

better error handling for rrelu when lower or upper range is infinite#160965

Closed
vishalgoyal316 wants to merge 2 commits intopytorch:mainfrom
vishalgoyal316:issue_153281
Closed

better error handling for rrelu when lower or upper range is infinite#160965
vishalgoyal316 wants to merge 2 commits intopytorch:mainfrom
vishalgoyal316:issue_153281

Conversation

@vishalgoyal316
Copy link
Collaborator

… - issue#153281

Fixes #153281

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160965

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2e4e922 with merge base 3a7db34 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vishalgoyal316
Copy link
Collaborator Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 19, 2025
@vishalgoyal316 vishalgoyal316 changed the title better error handling for rrelu when lower or upper range is infinite… better error handling for rrelu when lower or upper range is infinite Aug 20, 2025
@vishalgoyal316
Copy link
Collaborator Author

AI Assistance Disclosure

  • AI helped identify the root cause location in the codebase
  • AI suggested the bounds validation approach
  • Error messages and implementation were reviewed and customized for PyTorch standards
  • Solution follows existing PyTorch error handling patterns

@janeyx99 janeyx99 requested a review from mingfeima August 20, 2025 22:38
@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 20, 2025
@vishalgoyal316
Copy link
Collaborator Author

Thanks @janeyx99 for adding the reviewer.

Hello @mingfeima, is there any update on the review of this PR, thanks in advance.

@vishalgoyal316
Copy link
Collaborator Author

Hi @janeyx99, can you please add some more reviewer? as this PR has been open for a long time...

@vishalgoyal316
Copy link
Collaborator Author

vishalgoyal316 commented Sep 4, 2025

Hi @lezcano @nikitaved @IvanYashchuk,
This PR is still open for review, requesting to add more reviewer or please review if possible.

Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add test cases? I can review this myself

@vishalgoyal316
Copy link
Collaborator Author

can you add test cases? I can review this myself

Thanks, @janeyx99, I have added the test case for this PR, kindly review the same.

@isuruf
Copy link
Collaborator

isuruf commented Sep 22, 2025

@pytorchbot rebase -b viable/strict

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased issue_153281 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout issue_153281 && git pull --rebase)

Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@janeyx99
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 29, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@vishalgoyal316
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

torch.nn.functional.rrelu crashes on CPU with training=True when lower or upper is set to inf

5 participants