Skip to content

[MPS] Add support for log_normal_ #160339

Closed
Raman-RH wants to merge 4 commits intopytorch:mainfrom
Raman-RH:log-normal-mps
Closed

[MPS] Add support for log_normal_ #160339
Raman-RH wants to merge 4 commits intopytorch:mainfrom
Raman-RH:log-normal-mps

Conversation

@Raman-RH
Copy link
Copy Markdown
Contributor

@Raman-RH Raman-RH commented Aug 11, 2025 •
edited
Loading

We have this op in list of most requested ops in MPS backend

import torch
torch.manual_seed(42)
x = torch.tensor([0.0, 0.3, -0.5, 0.7], dtype=torch.float32, device='mps')
print(x.log_normal_(1, 1))

output:

tensor([6.7172, 3.3963, 3.1457, 5.6748], device='mps:0')

cc @alexsamardzic @nikitaved @pearu @cpuhrsch @amjames @bhosmer @jcaip @kulinseth @albanD @malfet @DenisVieriu97 @jhavukainen

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Aug 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160339

Note: Links to docs will display an error until the docs builds have been completed.

❌ 10 New Failures, 1 Pending

As of commit 8c270d5 with merge base fb5eb91 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: mps Release notes category label Aug 11, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 11, 2025 •
edited
Loading

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Resolved

@jerryzh168 jerryzh168 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 13, 2025
@kurtamohler kurtamohler mentioned this pull request Aug 19, 2025
Open
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 12, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Oct 12, 2025
@github-actions github-actions bot closed this Nov 11, 2025
@malfet malfet reopened this Jan 21, 2026
@malfet malfet added the topic: improvements topic category label Jan 21, 2026
@malfet
Copy link
Copy Markdown
Contributor

malfet commented Jan 21, 2026

@pytorchbot rebase

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jan 21, 2026

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jan 21, 2026

Successfully rebased log-normal-mps onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout log-normal-mps && git pull --rebase)

@malfet malfet added the ciflow/mps Run MPS tests (subset of trunk) label Jan 22, 2026
@malfet
Copy link
Copy Markdown
Contributor

malfet commented Jan 22, 2026

It has already been implemented

@malfet malfet closed this Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kulinseth kulinseth Awaiting requested review from kulinseth

@malfet malfet Awaiting requested review from malfet malfet is a code owner

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) open source release notes: mps Release notes category Stale topic: improvements topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Raman-RH @malfet @pytorchmergebot @jerryzh168 @pytorchbot