Skip to content

Fix skipIfXpu and skipIfHpu and similar skip decorators#159862

Open
Flamefire wants to merge 1 commit intopytorch:mainfrom
Flamefire:skipxpuhpu-markers
Open

Fix skipIfXpu and skipIfHpu and similar skip decorators#159862
Flamefire wants to merge 1 commit intopytorch:mainfrom
Flamefire:skipxpuhpu-markers

Conversation

@Flamefire
Copy link
Collaborator

@Flamefire Flamefire commented Aug 5, 2025

The decorators won't work when used on classes so use the unittest skip functions in their implementation.
In many cases those can be simple aliases.

Fixes #150779

@Flamefire Flamefire requested a review from a team as a code owner August 5, 2025 13:36
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159862

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 6b179bf with merge base 24e0e50 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Flamefire Flamefire force-pushed the skipxpuhpu-markers branch from cc7a1ec to 7984b83 Compare August 5, 2025 13:37
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 5, 2025
@Flamefire Flamefire force-pushed the skipxpuhpu-markers branch from 7984b83 to 6a8f9b9 Compare August 6, 2025 07:09
@Flamefire Flamefire changed the title Fix skipIfXpu and skipIfHp and similar skip decorators Fix skipIfXpu and skipIfHpu and similar skip decorators Aug 6, 2025
@Flamefire Flamefire force-pushed the skipxpuhpu-markers branch from 6a8f9b9 to 4876364 Compare August 6, 2025 07:38
@jerryzh168 jerryzh168 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 13, 2025
@Flamefire Flamefire force-pushed the skipxpuhpu-markers branch 2 times, most recently from 805ebf8 to e2db79a Compare November 10, 2025 08:49
@github-actions github-actions bot added the Stale label Mar 16, 2026
@Flamefire
Copy link
Collaborator Author

@pytorchbot rebase

@Flamefire Flamefire removed the Stale label Mar 17, 2026
@pytorch pytorch deleted a comment from github-actions bot Mar 17, 2026
@pytorch pytorch deleted a comment from pytorchmergebot Mar 17, 2026
@pytorch pytorch deleted a comment from pytorchmergebot Mar 17, 2026
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

The decorators won't work when used on classes so use the unittest skip
functions in their implementation.
In many cases those can be simple aliases.

Fixes pytorch#150779
@pytorchmergebot
Copy link
Collaborator

Successfully rebased skipxpuhpu-markers onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout skipxpuhpu-markers && git pull --rebase)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decorator skipIfXpu disables tests when used on class

4 participants