Skip to content

[vllm] add vllm test base docker image#158755

Closed
yangw-dev wants to merge 25 commits intomainfrom
step2vllmsetup
Closed

[vllm] add vllm test base docker image#158755
yangw-dev wants to merge 25 commits intomainfrom
step2vllmsetup

Conversation

@yangw-dev
Copy link
Contributor

@yangw-dev yangw-dev commented Jul 21, 2025 •
edited
Loading

description

Add base docker image for vllm.

It seems like we use the base docker image for both pytorch build, and tests. Configure a base image for vllm against pytorch CI.

Others

Added readme regarding how the base docker images are used, and how to add one, this also explain what is the right file to modify

yangw-dev added 2 commits July 21, 2025 10:15
@yangw-dev
setup link
4f2b5c1 
Signed-off-by: Yang Wang <elainewy@meta.com>
@yangw-dev
setup link
2c1abde 
Signed-off-by: Yang Wang <elainewy@meta.com>
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158755

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 4b131c8 with merge base 350d6af (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jul 21, 2025
yangw-dev added 2 commits July 21, 2025 10:43
@yangw-dev
setup link
558d92f 
Signed-off-by: Yang Wang <elainewy@meta.com>
@yangw-dev
setup link
bfa144b 
Signed-off-by: Yang Wang <elainewy@meta.com>
@yangw-dev yangw-dev changed the title add vllm step to docker build [vllm] add vllm step to docker build Jul 21, 2025
yangw-dev added 2 commits July 21, 2025 11:16
@yangw-dev
setup link
222d41f 
Signed-off-by: Yang Wang <elainewy@meta.com>
@yangw-dev
setup link
9028d8b 
Signed-off-by: Yang Wang <elainewy@meta.com>
@yangw-dev yangw-dev requested review from huydhn and seemethere July 21, 2025 18:46
yangw-dev added 2 commits July 21, 2025 11:48
@yangw-dev
setup link
8c6839d 
Signed-off-by: Yang Wang <elainewy@meta.com>
@yangw-dev
setup link
7f7613b 
Signed-off-by: Yang Wang <elainewy@meta.com>
yangw-dev
yangw-dev commented Jul 21, 2025
View reviewed changes
@yangw-dev yangw-dev marked this pull request as ready for review July 21, 2025 18:50
@yangw-dev yangw-dev requested review from a team and jeffdaily as code owners July 21, 2025 18:50
@yangw-dev yangw-dev marked this pull request as draft July 21, 2025 19:01
@yangw-dev yangw-dev changed the title [vllm] add vllm step to docker build [vllm] [not ready for review]add vllm step to docker build Jul 21, 2025
yangw-dev added 7 commits July 21, 2025 12:08
@yangw-dev
setup link
5f44504 
Signed-off-by: Yang Wang <elainewy@meta.com>
@yangw-dev
setup link
9cb70dd 
Signed-off-by: Yang Wang <elainewy@meta.com>
@yangw-dev
setup link
2cfed30 
Signed-off-by: Yang Wang <elainewy@meta.com>
@yangw-dev
setup link
9848408 
Signed-off-by: Yang Wang <elainewy@meta.com>
@yangw-dev
setup link
2066cee 
Signed-off-by: Yang Wang <elainewy@meta.com>
@yangw-dev
setup link
479ccbe 
Signed-off-by: Yang Wang <elainewy@meta.com>
@yangw-dev
setup link
70eefd4 
Signed-off-by: Yang Wang <elainewy@meta.com>
yangw-dev
yangw-dev commented Jul 21, 2025
View reviewed changes
.ci/docker/build.sh
pytorch-linux-jammy-cuda12.8-cudnn9-py3.12-gcc11-vllm)
CUDA_VERSION=12.8.1
CUDNN_VERSION=9
ANACONDA_PYTHON_VERSION=3.12
Copy link
Contributor Author

@yangw-dev yangw-dev Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this still call ANACONDA_PYTHON_VERSION? Wonder if it's a BE since we depreacte conda now

Copy link
Contributor

@huydhn huydhn Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been moved to conda-forge after #158370, maybe we should rename this accordingly cc @atalman

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 21, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 21, 2025

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

huydhn
huydhn approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yangw-dev yangw-dev marked this pull request as ready for review July 21, 2025 22:40
@yangw-dev
Copy link
Contributor Author

yangw-dev commented Jul 21, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 21, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 21, 2025

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@yangw-dev
Copy link
Contributor Author

yangw-dev commented Jul 22, 2025

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 22, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@yangw-dev
vllm setup
4b131c8 
Signed-off-by: Yang Wang <elainewy@meta.com>
@yangw-dev
Copy link
Contributor Author

yangw-dev commented Jul 22, 2025

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 22, 2025

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 22, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 22, 2025

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@yangw-dev
Copy link
Contributor Author

yangw-dev commented Jul 23, 2025

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 23, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the step2vllmsetup branch August 23, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@seemethere seemethere seemethere approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yangw-dev @pytorchmergebot @huydhn @seemethere