Skip to content

DCP safetensors test fix#158685

Closed
ankitageorge wants to merge 4 commits intomainfrom
dcp-safetensor-test-fix
Closed

DCP safetensors test fix#158685
ankitageorge wants to merge 4 commits intomainfrom
dcp-safetensor-test-fix

Conversation

@ankitageorge
Copy link
Contributor

@ankitageorge ankitageorge commented Jul 18, 2025 •
edited by pytorch-bot bot
Loading

#158069 removed the consolidated output path argument without updating the test. Reported by a user here #156705 (comment).
Adding back the logic from the original PR #158069 and fixing the test.

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158685

Note: Links to docs will display an error until the docs builds have been completed.

❌ 11 New Failures, 1 Unrelated Failure

As of commit d96fe6e with merge base badf002 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (checkpoint) labels Jul 18, 2025
@jithunnair-amd jithunnair-amd added the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Jul 18, 2025
@ankitageorge
Copy link
Contributor Author

ankitageorge commented Jul 18, 2025

@pytorchmergebot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 18, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 18, 2025

Merge started

Your change will be merged while ignoring the following 1 checks: pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu, unstable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 19, 2025

Merge failed

Reason: 2 jobs have failed, first few of them are: s390x-periodic / linux-manylinux-2_28-py3-cpu-s390x / test (default, 1, 10, linux.s390x), s390x-periodic / linux-manylinux-2_28-py3-cpu-s390x / test (default, 8, 10, linux.s390x)

Details for Dev Infra team Raised by workflow job

@ankitageorge
Copy link
Contributor Author

ankitageorge commented Jul 19, 2025

@pytorchmergebot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 19, 2025

Merge started

Your change will be merged while ignoring the following 3 checks: pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu, unstable), s390x-periodic / linux-manylinux-2_28-py3-cpu-s390x / test (default, 1, 10, linux.s390x), s390x-periodic / linux-manylinux-2_28-py3-cpu-s390x / test (default, 8, 10, linux.s390x)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 19, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: s390x-periodic / linux-manylinux-2_28-py3-cpu-s390x / test (default, 5, 10, linux.s390x)

Details for Dev Infra team Raised by workflow job

@ankitageorge
Copy link
Contributor Author

ankitageorge commented Jul 20, 2025

@pytorchmergebot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 20, 2025

Merge started

Your change will be merged while ignoring the following 12 checks: s390x-periodic / linux-manylinux-2_28-py3-cpu-s390x / test (default, 2, 10, linux.s390x), s390x-periodic / linux-manylinux-2_28-py3-cpu-s390x / test (default, 1, 10, linux.s390x), s390x-periodic / linux-manylinux-2_28-py3-cpu-s390x / test (default, 4, 10, linux.s390x), s390x-periodic / linux-manylinux-2_28-py3-cpu-s390x / test (default, 5, 10, linux.s390x), s390x-periodic / linux-manylinux-2_28-py3-cpu-s390x / test (default, 3, 10, linux.s390x), s390x-periodic / linux-manylinux-2_28-py3-cpu-s390x / test (default, 6, 10, linux.s390x), s390x-periodic / linux-manylinux-2_28-py3-cpu-s390x / test (default, 7, 10, linux.s390x), s390x-periodic / linux-manylinux-2_28-py3-cpu-s390x / test (default, 8, 10, linux.s390x), s390x-periodic / linux-manylinux-2_28-py3-cpu-s390x / test (default, 9, 10, linux.s390x), s390x-periodic / linux-manylinux-2_28-py3-cpu-s390x / test (default, 10, 10, linux.s390x), periodic / linux-jammy-cuda12.4-py3.10-gcc11 / test (legacy_nvidia_driver, 1, 5, linux.4xlarge.nvidia.gpu), periodic / linux-jammy-cuda12.8-py3-gcc11-slow-gradcheck / test (default, 7, 8, linux.g5.4xlarge.nvidia.gpu, module:slowgradcheck)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the dcp-safetensor-test-fix branch August 20, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@teja-rao teja-rao teja-rao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (checkpoint)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ankitageorge @pytorchmergebot @teja-rao @jithunnair-amd