Skip to content

Use init_device_mesh API for select tests where possible#158675

Closed
Electron4444 wants to merge 5 commits intopytorch:mainfrom
Electron4444:main
Closed

Use init_device_mesh API for select tests where possible#158675
Electron4444 wants to merge 5 commits intopytorch:mainfrom
Electron4444:main

Conversation

@Electron4444
Copy link
Contributor

@Electron4444 Electron4444 commented Jul 18, 2025

This addresses reviews made for:
#158538
#108749

It interchanged all the specific DevideMesh constructor calls with the API provided by the test cases, to improve abstraction

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158675

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 4 New Failures, 1 Unrelated Failure

As of commit 6563878 with merge base 79e49ef (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 18, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category labels Jul 18, 2025
@Electron4444 Electron4444 marked this pull request as draft July 18, 2025 20:50
Copy link
Contributor

@wconstab wconstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!
caution, depending on if other PRs land first, you may need to rebase to make sure you get all the tests covered

@Electron4444 Electron4444 marked this pull request as ready for review July 18, 2025 21:10
@Electron4444
Copy link
Contributor Author

Does this mean I should wait to merge?

@Electron4444
Copy link
Contributor Author

@pytorchmergebot merge

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 18, 2025

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

@Electron4444
Copy link
Contributor Author

@wconstab I'm very new to contributing to open-source projects and especially to working with these workflow or workflow operating bots
I'm unsure if I can and should skip the workflow, as the changes are very transparent and direct and shouldn't bother the linting or anything else.
Could you maybe tell me, if the workflows are needed and could you maybe approve them if you do think so?

@Electron4444
Copy link
Contributor Author

Thanks in advance

@wconstab
Copy link
Contributor

@wconstab I'm very new to contributing to open-source projects and especially to working with these workflow or workflow operating bots
I'm unsure if I can and should skip the workflow, as the changes are very transparent and direct and shouldn't bother the linting or anything else.
Could you maybe tell me, if the workflows are needed and could you maybe approve them if you do think so?

the workflows are definitely needed, you have to get a clean CI run before you can land. i approved the workflows. If all the tests are passing, you can type @pytorchbot merge and it will do the merge for you. If it complains about something, you may need to fix errors or rebase to a stable version of trunk (latest viable/strict is a good idea) and then i will have to re-trigger the workflows

@Electron4444
Copy link
Contributor Author

Sorry, made some stupid mistakes in 153ad85. PR is ready for retesting in Workflow now from my side

@Electron4444
Copy link
Contributor Author

@wconstab Could you approve the workflow? I think it should pass this time

@Electron4444
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 22, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants