Use init_device_mesh API for select tests where possible#158675
Use init_device_mesh API for select tests where possible#158675Electron4444 wants to merge 5 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158675
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 4 New Failures, 1 Unrelated FailureAs of commit 6563878 with merge base 79e49ef ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
wconstab
left a comment
There was a problem hiding this comment.
thanks for the fix!
caution, depending on if other PRs land first, you may need to rebase to make sure you get all the tests covered
|
Does this mean I should wait to merge? |
|
@pytorchmergebot merge |
|
Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra. |
|
@wconstab I'm very new to contributing to open-source projects and especially to working with these workflow or workflow operating bots |
|
Thanks in advance |
the workflows are definitely needed, you have to get a clean CI run before you can land. i approved the workflows. If all the tests are passing, you can type |
|
Sorry, made some stupid mistakes in 153ad85. PR is ready for retesting in Workflow now from my side |
|
@wconstab Could you approve the workflow? I think it should pass this time |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This addresses reviews made for:
#158538
#108749
It interchanged all the specific DevideMesh constructor calls with the API provided by the test cases, to improve abstraction
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta