Skip to content

[ROCm][CI] Last known good HIP patch#158596

Closed
naromero77amd wants to merge 5 commits intopytorch:mainfrom
ROCm:rocm_hip_reset2
Closed

[ROCm][CI] Last known good HIP patch#158596
naromero77amd wants to merge 5 commits intopytorch:mainfrom
ROCm:rocm_hip_reset2

Conversation

@naromero77amd
Copy link
Collaborator

@naromero77amd naromero77amd commented Jul 17, 2025 •
edited by jithunnair-amd
Loading

Fixes unit test breakage on ROCm CI caused by update to HIP custom branch in ROCm CI docker images.

Identical changes were extensively tested on ROCm via PR labels in #158562

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang

@naromero77amd naromero77amd requested a review from jeffdaily as a code owner July 17, 2025 22:05
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158596

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 150 Pending, 1 Unrelated Failure

As of commit 4e4a893 with merge base da4c7b4 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Jul 17, 2025
@naromero77amd naromero77amd changed the title [ROCm][CI] Last know good HIP patch [ROCm][CI] Last known good HIP patch Jul 17, 2025
@jeffdaily
Copy link
Collaborator

jeffdaily commented Jul 17, 2025

@pytorchbot merge -f "rocm CI emergency, roll back HIP patch, rocm-only change to docker images"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 17, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jithunnair-amd jithunnair-amd mentioned this pull request Jul 18, 2025
Closed
@jithunnair-amd jithunnair-amd deleted the rocm_hip_reset2 branch July 18, 2025 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffdaily jeffdaily jeffdaily approved these changes

Assignees

No one assigned

Labels

ciflow/rocm Trigger "default" config CI on ROCm Merged module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@naromero77amd @jeffdaily @pytorchmergebot @pytorchbot