Skip to content

Fix test linalg for MKL upgrading#158312

Closed
CaoE wants to merge 1 commit intopytorch:mainfrom
CaoE:fix_mkl
Closed

Fix test linalg for MKL upgrading#158312
CaoE wants to merge 1 commit intopytorch:mainfrom
CaoE:fix_mkl

Conversation

@CaoE
Copy link
Collaborator

@CaoE CaoE commented Jul 15, 2025

Fixes #158054

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158312

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit f5f7232 with merge base a5e6881 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jul 15, 2025
@CaoE CaoE added ciflow/slow ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor labels Jul 15, 2025
@CaoE CaoE mentioned this pull request Jul 15, 2025
Closed
@CaoE CaoE marked this pull request as ready for review July 15, 2025 05:07
@CaoE CaoE requested review from albanD and malfet July 15, 2025 06:04
albanD
albanD reviewed Jul 15, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why raising the precision the way to go here?
Was this change necessary in the numpy codebase where these tests are from?

@CaoE
Copy link
Collaborator Author

CaoE commented Jul 16, 2025

Why raising the precision the way to go here?

The new MKL version likely uses different strategies that produce mathematically equivalent but numerically slightly different results. I referred to other tests in this file, such as setting single_decimal=5 in CondCases. This way the changes are minimal and the impact is minimal.

Was this change necessary in the numpy codebase where these tests are from?

Are you saying that there are same tests in the numpy repository? If it is also tested with the new mkl, then it may need the same changes.

@CaoE CaoE requested a review from albanD July 17, 2025 02:21
albanD
albanD approved these changes Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok ok

@CaoE
Copy link
Collaborator Author

CaoE commented Jul 18, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 18, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

ciflow/inductor ciflow/slow ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DISABLED test_generalized_sq_cases (__main__.TestSolve)

4 participants

@CaoE @pytorchmergebot @albanD @pytorchbot