[Dynamo][Better Engineering] Add enhanced typing support to _dynamo/eval_frame.py#158276
Closed
Lucaskabela wants to merge 2 commits intomainfrom
Closed
[Dynamo][Better Engineering] Add enhanced typing support to _dynamo/eval_frame.py#158276Lucaskabela wants to merge 2 commits intomainfrom
_dynamo/eval_frame.py#158276Lucaskabela wants to merge 2 commits intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158276
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4e4ec45 with merge base 5a54db1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
789efdd to
437994f
Compare
Contributor
Author
|
@pytorchbot label "topic: not user facing" |
437994f to
e2ead9a
Compare
e2ead9a to
76f56da
Compare
_dynamo/eval_frame.py_dynamo/eval_frame.py
Lucaskabela
commented
Jul 15, 2025
| f_builtins: dict[str, object] | ||
| f_lasti: int | ||
| f_lineo: int | ||
| f_lineno: int |
Contributor
Author
There was a problem hiding this comment.
Improved typing helped catch this error :)
Lucaskabela
commented
Jul 15, 2025
|
|
||
| # TODO(voz): Do we want a decorator for this? | ||
| reset() | ||
| from .backends.debugging import ExplainOutput |
Contributor
Author
There was a problem hiding this comment.
Moved up to L1238 for typehint
_dynamo/eval_frame.py_dynamo/eval_frame.py
williamwen42
approved these changes
Jul 16, 2025
Co-authored-by: William Wen <williamwen@meta.com>
634f8c3 to
4e4ec45
Compare
Contributor
Author
|
@pytorchmergebot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of better engineering week, we would like to improve out type support to improve dev experience in dynamo
This PR adds strict typing support to the main entrypoint for dynamo,
eval_frame.pyRunning
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames