Skip to content

[BE] Raise ValueError from torch.cat meta func#158249

Closed
malfet wants to merge 5 commits intomainfrom
malfet-patch-10
Closed

[BE] Raise ValueError from torch.cat meta func#158249
malfet wants to merge 5 commits intomainfrom
malfet-patch-10

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Jul 14, 2025 •
edited
Loading

Followup after #155460

From Python documentation:

Raised when an operation or function receives an argument that has the right type but an inappropriate value, and the situation is not described by a more precise exception such as IndexError.

Raise TypeError when input-output types are incompatible with each other

Raised when an operation or function is applied to an object of inappropriate type. The associated value is a string giving details about the type mismatch.

This exception may be raised by user code to indicate that an attempted operation on an object is not supported, and is not meant to be. If an object is meant to support a given operation but has not yet provided an implementation, NotImplementedError is the proper exception to raise.

cc @albanD

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 14, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158249

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 1 Unrelated Failure

As of commit 4a9a6b5 with merge base 4869f71 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet requested a review from Skylion007 July 14, 2025 16:57
@malfet malfet added topic: bc breaking topic category module: python frontend For issues relating to PyTorch's Python frontend labels Jul 14, 2025
malfet
malfet commented Jul 14, 2025
View reviewed changes
jbschlosser
jbschlosser approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@jbschlosser jbschlosser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (modulo test), should we cherry pick this in to the 2.8 release?

@jbschlosser jbschlosser added the release notes: python_frontend python frontend release notes category label Jul 14, 2025
@malfet malfet requested a review from mruberry as a code owner July 16, 2025 04:04
@malfet malfet force-pushed the malfet-patch-10 branch from 7ac9d12 to 6cba647 Compare July 16, 2025 04:08
@malfet
Copy link
Contributor Author

malfet commented Jul 17, 2025

@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 17, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 17, 2025

Merge started

Your change will be merged while ignoring the following 1 checks: pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu, unstable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 17, 2025

Merge failed

Reason: 2 jobs have failed, first few of them are: linux-aarch64 / linux-jammy-aarch64-py3.10 / test (default, 3, 3, linux.arm64.m7g.4xlarge), linux-aarch64 / linux-jammy-aarch64-py3.10 / test (default, 2, 3, linux.arm64.m7g.4xlarge)

Details for Dev Infra team Raised by workflow job

malfet and others added 5 commits July 20, 2025 10:28
@malfet
[BE] Raise ValueError from torch.cat meta func
adff28e 
Followup after #155460

From [Python documentation](https://docs.python.org/3/library/exceptions.html#ValueError):
> Raised when an operation or function receives an argument that has the right type but an inappropriate value, and the situation is not described by a more precise exception such as IndexError.
@malfet
Update aten/src/ATen/native/TensorShape.cpp
202a353
@malfet
Fix test
08b10e0
@malfet
Adjust tests a bit
826b29c
@malfet
Fix those
4a9a6b5
@malfet malfet force-pushed the malfet-patch-10 branch from 9cf39a4 to 4a9a6b5 Compare July 20, 2025 17:34
@malfet
Copy link
Contributor Author

malfet commented Jul 20, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 20, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 20, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (default, 1, 2, linux.rocm.gpu.2)

Details for Dev Infra team Raised by workflow job

@malfet
Copy link
Contributor Author

malfet commented Jul 20, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 20, 2025

Merge started

Your change will be merged while ignoring the following 2 checks: trunk / macos-py3-arm64 / test (mps, 1, 1, macos-m1-13), trunk / linux-jammy-rocm-py3.10 / test (default, 1, 2, linux.rocm.gpu.2)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the malfet-patch-10 branch August 20, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@albanD albanD albanD approved these changes

@jbschlosser jbschlosser jbschlosser approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: python frontend For issues relating to PyTorch's Python frontend release notes: python_frontend python frontend release notes category topic: bc breaking topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malfet @pytorchmergebot @Skylion007 @albanD @jbschlosser