Skip to content

[reland][DTensor][FSDP2] necessary changes to FSDP and TP to unblock EP#158204

Closed
tianyu-l wants to merge 1 commit intomainfrom
ep2
Closed

[reland][DTensor][FSDP2] necessary changes to FSDP and TP to unblock EP#158204
tianyu-l wants to merge 1 commit intomainfrom
ep2

Conversation

@tianyu-l
Copy link
Contributor

@tianyu-l tianyu-l commented Jul 13, 2025

This PR is identical to #157216, which got reverted because of removing an outdated import of torch._dynamo https://www.internalfb.com/diff/D78021229?transaction_fbid=1713683499308113

The issue has been fixed by @weifengpy by D78199546, so this PR should be good to re-land.

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k

@tianyu-l tianyu-l requested a review from weifengpy July 13, 2025 18:34
@tianyu-l tianyu-l added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category release notes: distributed (dtensor) release notes category release notes: distributed (fsdp2) release notes category labels Jul 13, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158204

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 4aab788 with merge base 1f57e0e (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ci-no-td Do not run TD on this PR ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue labels Jul 13, 2025
@tianyu-l tianyu-l requested a review from wanchaol July 13, 2025 23:53
@tianyu-l
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (dtensor) release notes category release notes: distributed (fsdp2) release notes category topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants