don't error out in empty_cache under mempool context#158180
Merged
huydhn merged 1 commit intorelease/2.8from Jul 14, 2025
Merged
don't error out in empty_cache under mempool context#158180huydhn merged 1 commit intorelease/2.8from
huydhn merged 1 commit intorelease/2.8from
Conversation
Now instead of erroring out on `empty_cache` call during graph capture or under mempool context, we will just silently do nothing. This used to be the behavior for mempools, cudagraphs used to error out, but it's fine to just ignore the call. Pull Request resolved: #158152 Approved by: https://github.com/zou3519, https://github.com/eqy (cherry picked from commit 9056279)
This was referenced Jul 12, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158180
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit f9720fb with merge base 3a7ff82 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
huydhn
approved these changes
Jul 14, 2025
79 tasks
Contributor
|
Note: This can be verified by running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now instead of erroring out on
empty_cachecall during graph capture or under mempool context, we will just silently do nothing. This used to be the behavior for mempools, cudagraphs used to error out, but it's fine to just ignore the call.