Skip to content

[aot inductor] fix clang-asan for consts_cpp.#158175

Closed
xuhancn wants to merge 2 commits intopytorch:mainfrom
xuhancn:xu_fix_asan_for_consts_cpp
Closed

[aot inductor] fix clang-asan for consts_cpp.#158175
xuhancn wants to merge 2 commits intopytorch:mainfrom
xuhancn:xu_fix_asan_for_consts_cpp

Conversation

@xuhancn
Copy link
Collaborator

@xuhancn xuhancn commented Jul 12, 2025

From the perivous PR: #157608 , I added format_consts_to_cpp to build consts bytes.

But it still raise clang ASAN stack alloction, when build large size consts.

This PR:

  1. add test_aot_inductor_consts_cpp_build to stack allocation skip list.
  2. add ATTRIBUTE_NO_SANITIZE_ADDRESS to skip ASAN check, because consts array is locate in global area.

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158175

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit ba8b937 with merge base 92ee5bd (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@xuhancn xuhancn added topic: not user facing topic category ciflow/trunk Trigger trunk jobs on your pull request labels Jul 12, 2025
@xuhancn xuhancn added the intel This tag is for PR from Intel label Jul 12, 2025
@xuhancn xuhancn changed the title fix clang-asan for consts_cpp. [aot inductor] fix clang-asan for consts_cpp. Jul 12, 2025
@xuhancn xuhancn marked this pull request as ready for review July 12, 2025 03:08
@xuhancn xuhancn requested review from desertfire and jansel and removed request for desertfire and jansel July 12, 2025 03:08
@xuhancn
Copy link
Collaborator Author

xuhancn commented Jul 12, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@xuhancn xuhancn deleted the xu_fix_asan_for_consts_cpp branch July 12, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request intel This tag is for PR from Intel Merged module: inductor open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants