Skip to content

[ONNX] Delete torch.onnx.dynamo_export#158130

Closed
titaiwangms wants to merge 4 commits intopytorch:mainfrom
titaiwangms:titaiwang/delete_dynamo_export
Closed

[ONNX] Delete torch.onnx.dynamo_export#158130
titaiwangms wants to merge 4 commits intopytorch:mainfrom
titaiwangms:titaiwang/delete_dynamo_export

Conversation

@titaiwangms
Copy link
Collaborator

@titaiwangms titaiwangms commented Jul 11, 2025

It's deprecated since torch==2.7.

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158130

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 650fcac with merge base 92ee5bd (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Jul 11, 2025
@justinchuby justinchuby added the topic: bc breaking topic category label Jul 11, 2025
@justinchuby
Copy link
Collaborator

justinchuby commented Jul 11, 2025 •
edited
Loading

I forgot but I think we still need torch/onnx/_internal/fx/passes/type_promotion.py? Maybe copy it over to _exporter? (It doesn't need to inherit from Transform)

@titaiwangms
Copy link
Collaborator Author

titaiwangms commented Jul 11, 2025

I forgot but I think we still need torch/onnx/_internal/fx/passes/type_promotion.py? Maybe copy it over to _exporter? (It doesn't need to inherit from Transform)

I think we will need to split it anyway. I will restore and merge this one first. Probably need ghstack next time.

@titaiwangms
Copy link
Collaborator Author

titaiwangms commented Jul 11, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 11, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 11, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinchuby justinchuby justinchuby approved these changes

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@wschin wschin Awaiting requested review from wschin

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: bc breaking topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@titaiwangms @justinchuby @pytorchmergebot @pytorchbot