Documentation Fix: torch.empty_like memory preservation#158050
Closed
morrison-turnansky wants to merge 2 commits intopytorch:mainfrom
Closed
Documentation Fix: torch.empty_like memory preservation#158050morrison-turnansky wants to merge 2 commits intopytorch:mainfrom
morrison-turnansky wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158050
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 1eec311 with merge base a9537b6 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
Author
|
@ngimel Please let me know if the changes are sufficient. |
ngimel
reviewed
Jul 10, 2025
torch/_torch_docs.py
Outdated
| If the input tensor is dense (i.e., non-overlapping strided), | ||
| its memory format (including strides) is retained. | ||
| Otherwise (e.g., a non-dense view like a stepped slice), | ||
| the output is converted to the dense (contiguous) format. |
Collaborator
There was a problem hiding this comment.
contiguous is not correct, because stride permutation is preserved
Collaborator
Author
There was a problem hiding this comment.
@ngimel Thank you, I have updated the PR to reflect this.
ngimel
approved these changes
Jul 11, 2025
cyyever
approved these changes
Jul 14, 2025
Collaborator
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated docs for torch.empty_like to reflect view and dense memory behavior
Fixes #158022