Conversation
(not really fix these issues, but we should be able to close them and also to test them on CI) Fixes pytorch#156579 Fixes pytorch#156580 Fixes pytorch#126867 Signed-off-by: Huy Do <huydhn@gmail.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157756
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled Jobs, 2 PendingAs of commit 5be36ec with merge base ae1094b ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| torch._dynamo.utils.clear_compilation_metrics() | ||
|
|
||
| # https://github.com/pytorch/pytorch/issues/156580 | ||
| @serialTest() |
There was a problem hiding this comment.
could you explain why this fixes the test? Nothing immediately stands out to me
There was a problem hiding this comment.
Oh, I try different way to see if I could reproduce the failure locally, but I couldn't do it pytest -v test/dynamo/test_repros.py -k test_dont_dce_rand --flake-finder. My theory is that this running this test in parallel is to blame, so this is actually a test. I will need to wait till CI finishes to confirm if this fixes the flaky issue
There was a problem hiding this comment.
Running serially looks ok https://github.com/pytorch/pytorch/actions/runs/16131475437/job/45519980745#step:25:730
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 jobs have failed, first few of them are: inductor-rocm / rocm-py3.10-inductor / test (inductor, 2, 2, linux.rocm.gpu.2), inductor-rocm / rocm-py3.10-inductor / test (inductor, 1, 2, linux.rocm.gpu.2) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 2 checks: inductor-rocm / rocm-py3.10-inductor / test (inductor, 2, 2, linux.rocm.gpu.2), inductor-rocm / rocm-py3.10-inductor / test (inductor, 1, 2, linux.rocm.gpu.2) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot merge -f 'Some remaining ROCm jobs, should be fine' |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
(not really fix these issues, but we should be able to close them. This also allows CI from the PR to test them)
Fixes #156579
Fixes #156580
Fixes #126867
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov