[BE] Do not add . after troubleshooting_url#157753
Conversation
As it gets included into auto-hrefed URLs in say github logs to point to non existing location For example from https://github.com/pytorch/pytorch/actions/runs/16130448756/job/45517004735?pr=157749#step:18:27 > W0708 00:23:20.150000 67082 torch/_dynamo/convert_frame.py:1047] [0/8] To diagnose recompilation issues, see https://pytorch.org/docs/main/torch.compiler_troubleshooting.html.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157753
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 23 Pending, 1 Unrelated FailureAs of commit 377c57b with merge base bbb930a ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the trailing period from the troubleshooting URL placeholder in the diagnostic log message so that auto-hrefed links do not include an extra . and point to a non-existent location.
- Drop the
.at the end of theTo diagnose recompilation issues, see %sformat string - Preserve correct URL parsing in logs
| " last reason: %s\n" | ||
| 'To log all recompilation reasons, use TORCH_LOGS="recompiles".\n' | ||
| "To diagnose recompilation issues, see %s.", | ||
| "To diagnose recompilation issues, see %s", |
There was a problem hiding this comment.
[nitpick] Consider adding the sentence-ending period outside the placeholder so the log message retains proper punctuation without including it in the URL, e.g., "To diagnose recompilation issues, see %s."
| "To diagnose recompilation issues, see %s", | |
| "To diagnose recompilation issues, see %s.", |
|
@pytorchbot merge -f "Lint is green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
As it gets included into auto-hrefed URLs in say github logs to point to non existing location
For example from https://github.com/pytorch/pytorch/actions/runs/16130448756/job/45517004735?pr=157749#step:18:27
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames