Fixes issue #156414: Fixes bug in implementation of _combine_histograms.#156457
Closed
Akabbaj wants to merge 1 commit intopytorch:mainfrom
Akabbaj:fix-issue-156414
Closed
Fixes issue #156414: Fixes bug in implementation of _combine_histograms.#156457Akabbaj wants to merge 1 commit intopytorch:mainfrom Akabbaj:fix-issue-156414
Akabbaj wants to merge 1 commit intopytorch:mainfrom
Akabbaj:fix-issue-156414
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156457
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8184e5b with merge base 2625c70 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
The committers listed above are authorized under a signed CLA. |
Contributor
|
thanks can you help fix in https://github.com/pytorch/ao/blob/4e3d0198f93602d88db9d5ba6bb6020454fc5fde/torchao/quantization/pt2e/observer.py#L1251 as well |
jerryzh168
approved these changes
Jun 21, 2025
Contributor
jerryzh168
left a comment
There was a problem hiding this comment.
seems right to me, but I'll ask @TiRune take a look as well
Collaborator
|
@pytorchmergebot merge -i |
Collaborator
Merge startedYour change will be merged while ignoring the following 0 checks: Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #156414