[ROCm] test_hip_device_count safely runs on 1 GPU systems#156398
Closed
BLOrange-AMD wants to merge 3 commits intopytorch:mainfrom
Closed
[ROCm] test_hip_device_count safely runs on 1 GPU systems#156398BLOrange-AMD wants to merge 3 commits intopytorch:mainfrom
BLOrange-AMD wants to merge 3 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156398
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 385b504 with merge base 77518d1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jeffdaily
approved these changes
Jun 19, 2025
Collaborator
jeffdaily
left a comment
There was a problem hiding this comment.
This is only a problem if the testing systems has 1 GPU. Either we make this change or decorate the test to require 2 GPUs.
Contributor
Author
jeffdaily
reviewed
Jun 24, 2025
jeffdaily
approved these changes
Jun 26, 2025
Collaborator
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes test_cuda.py::TestCuda::test_hip_device_count on single gpu scenario
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd