Skip to content

Make dtensor tests device agnostic#155687

Closed
amathewc wants to merge 1 commit intopytorch:mainfrom
amathewc:dtensor6
Closed

Make dtensor tests device agnostic#155687
amathewc wants to merge 1 commit intopytorch:mainfrom
amathewc:dtensor6

Conversation

@amathewc
Copy link
Contributor

@amathewc amathewc commented Jun 11, 2025 •
edited by albanD
Loading

MOTIVATION

This PR is a continuation of #154840 and we are trying to make the tests more device agnostic by removing hard coded references to any particular device.
Please refer to this RFC as well: pytorch/rfcs#66

CHANGES

  1. test_convolution_ops.py:
    • Replace "cuda" with self.device_type
  2. test_random_ops.py:
    • Remove setting and using TYPE_DEVICE variable since device_type is set as per the environment (device) in DTensorTestBase class.
    • Replace "cuda" with self.device_type

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @ankurneog

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155687

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit fcc6812 with merge base f34ab16 (image):

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category labels Jun 11, 2025
@albanD albanD requested a review from wconstab June 11, 2025 12:51
@albanD albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 11, 2025
@amathewc
Copy link
Contributor Author

amathewc commented Jun 19, 2025

@albanD , @wconstab : Could you help in merging this ?

@albanD albanD requested a review from d4l3k June 20, 2025 22:25
d4l3k
d4l3k approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d4l3k
Copy link
Member

d4l3k commented Jun 20, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 20, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 20, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 21, 2025

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d4l3k d4l3k d4l3k approved these changes

@EikanWang EikanWang EikanWang approved these changes

@wconstab wconstab Awaiting requested review from wconstab

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@amathewc @d4l3k @pytorchmergebot @EikanWang @albanD @pytorchbot