Skip to content

Document the default garbage_collection_threshold value and improve the organization of cuda docs#155341

Closed
ParagEkbote wants to merge 2 commits intopytorch:mainfrom
ParagEkbote:update-cuda-params-docs
Closed

Document the default garbage_collection_threshold value and improve the organization of cuda docs#155341
ParagEkbote wants to merge 2 commits intopytorch:mainfrom
ParagEkbote:update-cuda-params-docs

Conversation

@ParagEkbote
Copy link
Contributor

@ParagEkbote ParagEkbote commented Jun 6, 2025 •
edited by pytorch-bot bot
Loading

Fixes #150917

As mentioned in the issue, I've updated the documentation of garbage_collection_thresholdand improved the organization.

Could you please review?

cc @svekars @sekyondaMeta @AlannaBurke @ptrblck @msaroufim @eqy @jerryzh168

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 6, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155341

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 24 Pending

As of commit 24fe9f9 with merge base 529e035 (image):
💚 Looks good so far! There are no failures yet. 💚

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 6, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added docathon-h1-2025 easy label for easy docathon tasks module: cuda Related to torch.cuda, and CUDA support in general module: docs Related to our documentation, both in docs/ and docblocks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jun 6, 2025
@svekars svekars added the topic: not user facing topic category label Jun 6, 2025
@ParagEkbote
Copy link
Contributor Author

ParagEkbote commented Jun 6, 2025

@pytorchbot label "topic: docs"

@pytorch-bot pytorch-bot bot added the topic: docs topic category label Jun 6, 2025
@ParagEkbote
Copy link
Contributor Author

ParagEkbote commented Jun 6, 2025

@pytorchbot label "topic: not user facing"

@jerryzh168 jerryzh168 requested a review from ngimel June 6, 2025 23:17
@svekars
Copy link
Contributor

svekars commented Jun 8, 2025

@pytorchbot merge -f "Minor doc fix. Doc signal is green."

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 8, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ParagEkbote ParagEkbote deleted the update-cuda-params-docs branch June 9, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlannaBurke AlannaBurke AlannaBurke approved these changes

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

docathon-h1-2025 easy label for easy docathon tasks Merged module: cuda Related to torch.cuda, and CUDA support in general module: docs Related to our documentation, both in docs/ and docblocks open source topic: docs topic category topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document garbage_collection_threshold default

6 participants

@ParagEkbote @svekars @pytorchmergebot @AlannaBurke @ngimel @pytorchbot