Skip to content

Custom FX pass for inductor's backend registration#154841

Closed
marpioch wants to merge 19 commits intopytorch:mainfrom
marpioch:custom_backend_pass
Closed

Custom FX pass for inductor's backend registration#154841
marpioch wants to merge 19 commits intopytorch:mainfrom
marpioch:custom_backend_pass

Conversation

@marpioch
Copy link
Contributor

@marpioch marpioch commented Jun 2, 2025 •
edited
Loading

This PR is related to RFC #153532. It is an extension to Inductor's backend registration interface to allow to register custom FX passes by the backend.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @Valentine233 @leslie-fang-intel @Xia-Weiwen @jansel

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154841

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0e7aec0 with merge base 6020440 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 2, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@marpioch marpioch force-pushed the custom_backend_pass branch from e4989af to 24ea25d Compare June 2, 2025 10:51
@marpioch marpioch marked this pull request as draft June 2, 2025 10:52
@marpioch marpioch force-pushed the custom_backend_pass branch from 24ea25d to 9b88af9 Compare June 2, 2025 10:55
@marpioch
Copy link
Contributor Author

marpioch commented Jun 2, 2025

@pytorchbot label "release notes: inductor"

@marpioch marpioch marked this pull request as ready for review June 2, 2025 12:42
jansel
jansel requested changes Jun 2, 2025
View reviewed changes
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 3, 2025
jansel
jansel requested changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@jansel jansel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures?

@marpioch
Copy link
Contributor Author

marpioch commented Jun 4, 2025

Test failures?

Needed to improve existing get_all_devices function.

jansel
jansel previously approved these changes Jun 4, 2025
View reviewed changes
@jansel
Copy link
Contributor

jansel commented Jun 4, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 4, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 4, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 4, 2025

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@marpioch
Copy link
Contributor Author

marpioch commented Jun 4, 2025

@jansel , pull / linux-jammy-cuda12.8-cudnn9-py3.9-clang12 / build (gh) job failed and I cannot see any related issue to my changes. Should we try to re-run this?

@jansel
Copy link
Contributor

jansel commented Jun 5, 2025

@marpioch I restarted the job

@jansel
Copy link
Contributor

jansel commented Jun 5, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 5, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@jansel
Copy link
Contributor

jansel commented Jun 11, 2025

Looks like merge conflicts.

@jansel jansel added ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request labels Jun 13, 2025
@jansel
Copy link
Contributor

jansel commented Jun 13, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 13, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 13, 2025

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@pytorch-bot pytorch-bot bot removed ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor labels Jun 13, 2025
@jansel jansel added ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor labels Jun 14, 2025
@jansel
Copy link
Contributor

jansel commented Jun 14, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 14, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 14, 2025

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@jansel
Copy link
Contributor

jansel commented Jun 14, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 14, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@Xia-Weiwen Xia-Weiwen mentioned this pull request Jul 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor open source release notes: inductor Reverted triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@marpioch @jansel @pytorchmergebot @EikanWang @clee2000 @soulitzer @pytorchbot