Skip to content

Split up compiler.cpp#15355

Closed
zdevito wants to merge 6 commits intopytorch:masterfrom
zdevito:pr/compiler
Closed

Split up compiler.cpp#15355
zdevito wants to merge 6 commits intopytorch:masterfrom
zdevito:pr/compiler

Conversation

@zdevito
Copy link
Contributor

@zdevito zdevito commented Dec 18, 2018

This separates the different parts of compiler.cpp to make their relationship more clear. In particular it adds:

  • sugared_value.{h,cpp} - all the public SugaredValues that the compiler defines and a few that were inside compiler.cpp
  • type_parser.{h, cpp} - Turns TreeRef's defining types into TypePtr
  • schema_matching.{h, cpp} - infrastructure for matching arguments against overloaded schema and emitting builtin operators with a particular schema.
    Retains:
  • compiler.{h, cpp} - now responsible simply for the defineMethodsInModule infra structure.

Some utility functions like inlineCallTo have moved to ir.h.

Only thing that is not a move is some changes in module.h/cpp that remove multiple returns from Method::emit_call_to.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Dec 18, 2018
Copy link
Member

@suo suo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamping in the interest of minimizing potential breakage window

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zdevito has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants