Skip to content

[BE]: Enable ruff YTT linter for Python version checks#153547

Closed
Skylion007 wants to merge 1 commit intopytorch:mainfrom
Skylion007:skylion007/enable-ruff-YTT-rules-2025-05-14
Closed

[BE]: Enable ruff YTT linter for Python version checks#153547
Skylion007 wants to merge 1 commit intopytorch:mainfrom
Skylion007:skylion007/enable-ruff-YTT-rules-2025-05-14

Conversation

@Skylion007
Copy link
Collaborator

Adds ruff YTT checks to help future proof version checks and follow best practices here. Also makes it easier for static linters like mypy to detect python version branching.

@pytorch-bot
Copy link

pytorch-bot bot commented May 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153547

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 93afe23 with merge base cd119dd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@Skylion007
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 14, 2025
@Skylion007 Skylion007 added topic: not user facing topic category better-engineering Relatively self-contained tasks for better engineering contributors and removed ciflow/trunk Trigger trunk jobs on your pull request labels May 14, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@Skylion007 Skylion007 removed open source better-engineering Relatively self-contained tasks for better engineering contributors Merged labels May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants