Skip to content

[Ez][BE]: Fix click ImportError in torch/csrc/jit#153323

Closed
Skylion007 wants to merge 1 commit intopytorch:mainfrom
Skylion007:skylion007/fix-click-import-2025-05-10
Closed

[Ez][BE]: Fix click ImportError in torch/csrc/jit#153323
Skylion007 wants to merge 1 commit intopytorch:mainfrom
Skylion007:skylion007/fix-click-import-2025-05-10

Conversation

@Skylion007
Copy link
Copy Markdown
Collaborator

@Skylion007 Skylion007 commented May 10, 2025

Fixes unnecessary import for torch script. Unblocks #153020 as it appears to fix circular importer linter into importing every Python file under torch

cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153323

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 2972efc with merge base 70c8047 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 10, 2025
@Skylion007 Skylion007 marked this pull request as ready for review May 10, 2025 14:01
@Skylion007 Skylion007 added the better-engineering Relatively self-contained tasks for better engineering contributors label May 10, 2025
@Skylion007 Skylion007 changed the title [BE]: Fix click ImportError in torch/csrc/jit [Ez][BE]: Fix click ImportError in torch/csrc/jit May 10, 2025
@Skylion007 Skylion007 requested a review from xuhancn May 10, 2025 16:33
@Skylion007
Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 11, 2025
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged NNC oncall: jit Add this issue/PR to JIT oncall triage queue open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants