Skip to content

[Ez][BE]: Ensure matplotlib remains optional dependency via fake_quantize#153244

Closed
Skylion007 wants to merge 1 commit intopytorch:mainfrom
Skylion007:skylion007/move-unguarded-matplotlib-2025-05-09
Closed

[Ez][BE]: Ensure matplotlib remains optional dependency via fake_quantize#153244
Skylion007 wants to merge 1 commit intopytorch:mainfrom
Skylion007:skylion007/move-unguarded-matplotlib-2025-05-09

Conversation

@Skylion007
Copy link
Collaborator

@Skylion007 Skylion007 commented May 9, 2025 •
edited
Loading

Unblocks #153055 and ensure that matplotlib should always be optional in PyTorch.

@pytorch-bot
Copy link

pytorch-bot bot commented May 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153244

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit d43a01d with merge base 42b3e56 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Skylion007 Skylion007 force-pushed the skylion007/move-unguarded-matplotlib-2025-05-09 branch from 6090cf3 to d43a01d Compare May 9, 2025 14:13
albanD
albanD approved these changes May 9, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Skylion007
Copy link
Collaborator Author

Skylion007 commented May 9, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 9, 2025
@Skylion007 Skylion007 added topic: not user facing topic category and removed ciflow/trunk Trigger trunk jobs on your pull request labels May 9, 2025
@Skylion007 Skylion007 modified the milestones: 2.8.0, 2.7.1 May 9, 2025
@Skylion007 Skylion007 added the better-engineering Relatively self-contained tasks for better engineering contributors label May 9, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented May 9, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented May 9, 2025

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@Skylion007
Copy link
Collaborator Author

Skylion007 commented May 9, 2025

@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 9, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented May 9, 2025

Merge started

Your change will be merged while ignoring the following 2 checks: pull / linux-focal-py3_9-clang9-xla / build, pull / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, lf.ephemeral.linux.2xlarge)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented May 9, 2025

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@Skylion007
Copy link
Collaborator Author

Skylion007 commented May 9, 2025

@pytorchbot merge -i "irrelevant failures"

@pytorch-bot
Copy link

pytorch-bot bot commented May 9, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: irrelevant failures

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@Skylion007
Copy link
Collaborator Author

Skylion007 commented May 9, 2025

@pytorchbot merge -f "irrelevant failures"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented May 9, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman
Copy link
Contributor

atalman commented May 15, 2025

@Skylion007 Please note this, existed for release 2.6 and 2.5 : https://github.com/pytorch/pytorch/blob/release/2.6/torch/ao/quantization/experimental/observer.py#L9
It does not fit our cherry-picking criteria for patch releases . Hence removing 2.7.1 milestone

@atalman atalman removed this from the 2.7.1 milestone May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@malfet malfet Awaiting requested review from malfet

@atalman atalman Awaiting requested review from atalman

@XuehaiPan XuehaiPan Awaiting requested review from XuehaiPan

Assignees

No one assigned

Labels

better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: AO frontend release notes: quantization release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Skylion007 @pytorchmergebot @atalman @albanD @pytorchbot