[Dynamo] Replace unimplemented with unimplemented_v2 in torch/_dynamo/variables/tensor.py#153146
[Dynamo] Replace unimplemented with unimplemented_v2 in torch/_dynamo/variables/tensor.py#153146shink wants to merge 12 commits intopytorch:mainfrom
unimplemented with unimplemented_v2 in torch/_dynamo/variables/tensor.py#153146Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153146
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 4e8e038 with merge base 2908c10 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
torch/_dynamo/variables/tensor.py
Outdated
There was a problem hiding this comment.
What should explanation look like? Anyone can help?
There was a problem hiding this comment.
Dynamo does not support changes to a Tensor's requires_grad through calling requires_grad_().
|
@pytorchbot label "topic: not user facing" |
williamwen42
left a comment
There was a problem hiding this comment.
I would be more conservative on suggesting SUPPORTABLE because we don't know how difficult it would be to support some of these.
torch/_dynamo/variables/tensor.py
Outdated
There was a problem hiding this comment.
This is a fundamental graph break.
There was a problem hiding this comment.
Many thanks for your review. Have updated in this commit: 4d3fa9d
torch/_dynamo/variables/tensor.py
Outdated
There was a problem hiding this comment.
Dynamo does not support changes to a Tensor's requires_grad through calling requires_grad_().
|
@pytorchbot rebase -b main |
|
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
|
Successfully rebased |
8fc6718 to
3bdcb79
Compare
williamwen42
left a comment
There was a problem hiding this comment.
Let's leave out SUPPORTABLE graph break hints for now unless we think a graph break really could be reasonably supported. The mindset behind a SUPPORTABLE graph break should be "this is technically feasible but we haven't had the time to get around to it yet." But a lot of these graph breaks I don't have much of an idea how easy they are to support.
|
@pytorchbot rebase -b main |
|
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
|
Successfully rebased |
3bdcb79 to
a847db7
Compare
|
@williamwen42 Sorry for the late update. Could your please take another look? Thank you for your time! |
|
@pytorchbot rebase -b main |
|
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
|
Successfully rebased |
c5bba35 to
c6b7893
Compare
afa5ed3 to
f00a27a
Compare
|
@pytorchbot merge |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot rebase -b main |
|
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
Co-authored-by: William Wen <william.wen42@gmail.com>
Co-authored-by: William Wen <william.wen42@gmail.com>
|
Successfully rebased |
afa1fd8 to
4e8e038
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Part of #147913
Replace
unimplementedwithunimplemented_v2intorch/_dynamo/variables/tensor.pycc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames