Skip to content

Mini tutorial for provenance tracking#152211

Closed
yushangdi wants to merge 4 commits intomainfrom
provenance_doc
Closed

Mini tutorial for provenance tracking#152211
yushangdi wants to merge 4 commits intomainfrom
provenance_doc

Conversation

@yushangdi
Copy link
Contributor

@yushangdi yushangdi commented Apr 25, 2025

as title

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152211

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 65095c3 with merge base 1d77280 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 25, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@yushangdi
Copy link
Contributor Author

/easycla

@yushangdi yushangdi added the topic: docs topic category label Apr 25, 2025
@pytorch pytorch deleted a comment from github-actions bot Apr 25, 2025
@yushangdi yushangdi added release notes: export and removed topic: docs topic category labels Apr 25, 2025
@pytorch pytorch deleted a comment from github-actions bot Apr 25, 2025

logging
torch.compiler_aot_inductor_minifier
torch.compiler_inductor_provenance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not just an AOTInductor debugging tool, right? It is also a torch.compile debugging tool

TorchInductor and AOTInductor Provenance Tracking
=================================================

**Author:** `Shangdi Yu <https://github.com/yushangdi>`__ and `Rachel Guo <https://github.com/YUNQIUGUO>`__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you plan to keep this section here - can you please remove the Author line - we typically add this in the tutorials repo but not in regular doc sections.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll move it to the tutorial repo.

.. image:: _static/img/inductor_provenance/provenance_aot_inductor.png


Get Started
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more detailed heading would be better I think

Suggested change
Get Started
Setting up the provenance tracking

.. raw:: html

<style>
.yellow {background-color:#FFFF00;}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this !

@yushangdi yushangdi requested a review from svekars May 5, 2025 18:00
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few editorial suggestions - let me know if you have any questions.

@yushangdi yushangdi requested a review from svekars May 5, 2025 21:38
@yushangdi
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased provenance_doc onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout provenance_doc && git pull --rebase)

Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really minor nits - otherwise LGTM from the publishing perspective. Someone with more technical expertise, needs to approve as well.

Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really minor nits - otherwise LGTM from the publishing perspective. Someone with more technical expertise, needs to approve as well.

@yushangdi yushangdi requested review from eellison and zou3519 May 7, 2025 21:10
@yushangdi
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 8, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the provenance_doc branch June 17, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: export

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants