Remove mention of magma-cuda in readme.md, refactor magma_conda install by atalman · Pull Request #147476 · pytorch/pytorch

atalman · 2025-02-19T20:01:49Z

Related to: #138506 we migrated magma-cuda build from anaconda to aws
Last version of magma-cuda published was 12.6 https://anaconda.org/pytorch/magma-cuda126

Here is the PR that moved from anaconda to tarball: #140417

cc @malfet @afrittoli @seemethere @albanD

pytorch-bot · 2025-02-19T20:01:55Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147476

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit af605d0 with merge base 40cf49d ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / linux-focal-py3_9-clang9-xla / test (xla, 1, 1, lf.linux.12xlarge) (gh) (matched linux rule in flaky-rules.json)
E: Failed to fetch http://deb.debian.org/debian/pool/main/libx/libxml-parser-perl/libxml-parser-perl_2.46-2_amd64.deb Error reading from server - read (104: Connection reset by peer) [IP: 146.75.34.132 80]

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / linux-focal-py3.13-clang10 / test (default, 5, 5, lf.linux.4xlarge) (gh) (trunk failure)
dynamo/test_utils.py::TestDynamoTimed::test_dynamo_timed
pull / linux-focal-py3.9-clang10 / test (default, 3, 5, lf.linux.4xlarge) (gh) (trunk failure)
dynamo/test_utils.py::TestDynamoTimed::test_dynamo_timed
pull / linux-jammy-py3.10-clang15-asan / test (default, 6, 6, lf.linux.4xlarge) (gh) (trunk failure)
dynamo/test_utils.py::TestDynamoTimed::test_dynamo_timed
trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable) (gh) (trunk failure)
dynamo/test_utils.py::TestDynamoTimed::test_dynamo_timed

This comment was automatically generated by Dr. CI and updates every 15 minutes.

atalman · 2025-02-19T20:09:31Z

We should probably move this script to : https://github.com/pytorch/pytorch/tree/main/scripts to make it more user friendly

afrittoli

Thank you, it looks good!

albanD · 2025-02-19T22:04:15Z

Is $CONDA_PREFIX always set when a conda environment is enabled?

Yes please refer to: https://docs.conda.io/projects/conda/en/latest/user-guide/tasks/manage-environments.html#macos-and-linux

Added fallback

albanD

Change sounds ok.

atalman · 2025-04-21T20:18:15Z

@pytorchmergebot merge

pytorchmergebot · 2025-04-21T20:20:20Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-04-21T20:20:46Z

Merge failed

Reason: 11 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

atalman · 2025-04-22T02:36:48Z

@pytorchmergebot rebase -b main

pytorchmergebot · 2025-04-22T02:38:16Z

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

pytorchmergebot · 2025-04-22T02:38:20Z

Successfully rebased refactor_magma_install onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout refactor_magma_install && git pull --rebase)

atalman · 2025-04-22T21:59:46Z

@pytorchmergebot merge -i

pytorchmergebot · 2025-04-22T22:03:10Z

Merge started

Your change will be merged while ignoring the following 5 checks: pull / linux-focal-py3.13-clang10 / test (default, 5, 5, lf.linux.4xlarge), pull / linux-jammy-py3.10-clang15-asan / test (default, 6, 6, lf.linux.4xlarge), pull / linux-focal-py3.9-clang10 / test (default, 3, 5, lf.linux.4xlarge), pull / linux-focal-py3_9-clang9-xla / test (xla, 1, 1, lf.linux.12xlarge), trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

youkaichao · 2025-06-15T07:31:26Z

there're still lots of places in readme mentioning conda, like which conda and .ci/docker/common/install_magma_conda.sh 12.4 . are they still necessary? or we can remove them as well?

wondering if we can just ignore those and install with a fresh new venv environment.

atalman requested a review from jeffdaily as a code owner February 19, 2025 20:01

pytorch-bot Bot added the topic: not user facing topic category label Feb 19, 2025

atalman commented Feb 19, 2025

View reviewed changes

Comment thread .ci/docker/common/install_magma_conda.sh Outdated

afrittoli reviewed Feb 19, 2025

View reviewed changes

albanD reviewed Feb 19, 2025

View reviewed changes

atalman requested a review from a team as a code owner February 27, 2025 04:30

atalman commented Mar 17, 2025

View reviewed changes

Comment thread README.md Outdated

atalman force-pushed the refactor_magma_install branch from f05aa98 to 0620efb Compare March 18, 2025 13:39

albanD approved these changes Apr 9, 2025

View reviewed changes

pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 21, 2025

pytorchmergebot added the merging label Apr 21, 2025

pytorchmergebot removed the merging label Apr 21, 2025

atalman added 5 commits April 22, 2025 02:38

Remove metion of magma-cuda in readme.md, refactor magma_conda install

5c100b1

Remove second param to magma install

3452e3f

Add description

c3fd64b

fix

84b3c05

Add fallback for conda parefix

af605d0

pytorchmergebot force-pushed the refactor_magma_install branch from 0620efb to af605d0 Compare April 22, 2025 02:38

pytorchmergebot added the merging label Apr 22, 2025

pytorchmergebot added the Merged label Apr 22, 2025

pytorchmergebot closed this in 43de9b7 Apr 22, 2025

pytorchmergebot removed the merging label Apr 22, 2025

Conversation

atalman commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147476

✅ You can merge normally! (5 Unrelated Failures)

Uh oh!

atalman Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

afrittoli left a comment

Choose a reason for hiding this comment

Uh oh!

albanD Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

atalman Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

atalman Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

albanD left a comment

Choose a reason for hiding this comment

Uh oh!

atalman commented Apr 21, 2025

Uh oh!

pytorchmergebot commented Apr 21, 2025

Merge started

Uh oh!

pytorchmergebot commented Apr 21, 2025

Merge failed

Uh oh!

atalman commented Apr 22, 2025

Uh oh!

pytorchmergebot commented Apr 22, 2025

Uh oh!

pytorchmergebot commented Apr 22, 2025

Uh oh!

atalman commented Apr 22, 2025

Uh oh!

pytorchmergebot commented Apr 22, 2025

Merge started

Uh oh!

youkaichao commented Jun 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

atalman commented Feb 19, 2025 •

edited

Loading

pytorch-bot Bot commented Feb 19, 2025 •

edited

Loading