Skip to content

Re-add stft option to align window for center = false#146379

Closed
jackzhxng wants to merge 8 commits intomainfrom
jz/stft-test
Closed

Re-add stft option to align window for center = false#146379
jackzhxng wants to merge 8 commits intomainfrom
jz/stft-test

Conversation

@jackzhxng
Copy link
Contributor

@jackzhxng jackzhxng commented Feb 4, 2025

Skips advancing the fc window on #145437, since I just found that there were non-trivial efforts to do so a while ago that eventually was reverted: #73434

Works around the issue by keeping the stft sans center overload

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Feb 4, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146379

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit 68cb6ba with merge base cd6c070 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.


Caused by:

@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results February 4, 2025 03:20 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results February 4, 2025 03:20 Inactive
@pytorch-bot pytorch-bot bot had a problem deploying to upload-benchmark-results February 4, 2025 16:35 Failure
@pytorch-bot pytorch-bot bot had a problem deploying to upload-benchmark-results February 4, 2025 16:35 Error
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results February 4, 2025 18:49 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results February 4, 2025 18:49 Inactive
@jackzhxng
Copy link
Contributor Author

@justinchuby @titaiwangms can you take a look at this one? #145437 which you reviewed got reverted, so I'm skipping it

@jackzhxng jackzhxng requested a review from iseeyuan February 4, 2025 21:40
Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ONNX changes lgtm

@jackzhxng jackzhxng changed the title Jz/stft test Re-add stft option to align window for center = false Feb 4, 2025
Copy link
Contributor

@iseeyuan iseeyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pytorch-bot pytorch-bot bot had a problem deploying to upload-benchmark-results February 4, 2025 23:16 Failure
@pytorch-bot pytorch-bot bot had a problem deploying to upload-benchmark-results February 4, 2025 23:16 Failure
@jackzhxng
Copy link
Contributor Author

@huydhn would you know what is going on with the linter test?

@pytorch-bot pytorch-bot bot had a problem deploying to upload-benchmark-results February 5, 2025 17:50 Failure
@pytorch-bot pytorch-bot bot had a problem deploying to upload-benchmark-results February 5, 2025 17:50 Error
@huydhn
Copy link
Contributor

huydhn commented Feb 5, 2025

@pytorchbot merge -r

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 5, 2025
@huydhn
Copy link
Contributor

huydhn commented Feb 5, 2025

@huydhn would you know what is going on with the linter test?

That can be fixed by a rebase, so let's just merge -r and you're good to go

@pytorchmergebot
Copy link
Collaborator

Successfully rebased jz/stft-test onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout jz/stft-test && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 jobs have failed, first few of them are: trunk / linux-focal-rocm6.3-py3.10 / test (default, 1, 2, linux.rocm.gpu.2), trunk / linux-focal-rocm6.3-py3.10 / test (distributed, 1, 1, linux.rocm.gpu.4)

Details for Dev Infra team Raised by workflow job

@huydhn
Copy link
Contributor

huydhn commented Feb 5, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 jobs have failed, first few of them are: trunk / linux-focal-rocm6.3-py3.10 / test (default, 2, 2, linux.rocm.gpu.2), trunk / linux-focal-rocm6.3-py3.10 / test (distributed, 1, 1, linux.rocm.gpu.4)

Details for Dev Infra team Raised by workflow job

@atalman
Copy link
Contributor

atalman commented Feb 6, 2025

@pytorchmergebot merge -f "rocm failures are not related"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn
Copy link
Contributor

huydhn commented Feb 6, 2025

@pytorchbot drci

3 similar comments
@huydhn
Copy link
Contributor

huydhn commented Feb 6, 2025

@pytorchbot drci

@huydhn
Copy link
Contributor

huydhn commented Feb 6, 2025

@pytorchbot drci

@huydhn
Copy link
Contributor

huydhn commented Feb 6, 2025

@pytorchbot drci

@github-actions github-actions bot deleted the jz/stft-test branch March 9, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/slow ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: onnx torch.onnx related changes that should show up in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants