Use random64 in Fischer-Yates algorithm for large N (#143682)#144735
Merged
Conversation
Fixes bug in randperm https://nbsanity.com/static/a4774194938414dedcec7d6e99727d31/Shuffling_20in_20torch_20vs_20numpy-public.html Pull Request resolved: #143682 Approved by: https://github.com/eqy, https://github.com/albanD, https://github.com/malfet
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144735
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a73213a with merge base f7e621c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug in randperm https://nbsanity.com/static/a4774194938414dedcec7d6e99727d31/Shuffling_20in_20torch_20vs_20numpy-public.html
Pull Request resolved: #143682
Approved by: https://github.com/eqy, https://github.com/albanD, https://github.com/malfet
Fixes #ISSUE_NUMBER