Skip to content

Add check_binary workflow to pytorch/pytorch#143201

Closed
atalman wants to merge 5 commits intopytorch:mainfrom
atalman:add_check_binary_workflow
Closed

Add check_binary workflow to pytorch/pytorch#143201
atalman wants to merge 5 commits intopytorch:mainfrom
atalman:add_check_binary_workflow

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Dec 13, 2024 •
edited
Loading

Migrated from pytorch/builder
Related to: pytorch/builder#2054

Copying from : pytorch/builder@3468139

@atalman atalman requested a review from a team as a code owner December 13, 2024 16:52
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 13, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 13, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143201

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5355eaf with merge base 3f62054 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman atalman mentioned this pull request Dec 13, 2024
Open
14 tasks
seemethere
seemethere approved these changes Dec 13, 2024
View reviewed changes
malfet
malfet approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please specify the exact version you are copying it from

@atalman
Copy link
Contributor Author

atalman commented Dec 13, 2024

@pytorchmergebot merge -f "lint and check_binary is green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 13, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere seemethere approved these changes

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atalman @pytorchmergebot @seemethere @malfet