Skip to content

Cuda 12.1 - Remove from trunk tests#143076

Closed
atalman wants to merge 3 commits intopytorch:mainfrom
atalman:add_cuda124_test
Closed

Cuda 12.1 - Remove from trunk tests#143076
atalman wants to merge 3 commits intopytorch:mainfrom
atalman:add_cuda124_test

Conversation

@atalman
Copy link
Copy Markdown
Contributor

@atalman atalman commented Dec 11, 2024 •
edited
Loading

Remove cuda 12.1 from trunk tests. This is covered by 12.4 tests.
Move libtorch-linux-focal-cuda12_4-py3_7-gcc9-debug-build -> libtorch-linux-focal-cuda12_4-py3_10-gcc9-debug-build

@atalman atalman requested a review from a team as a code owner December 11, 2024 23:04
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Dec 11, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143076

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 487324e with merge base 1b3f8b7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 11, 2024
huydhn
huydhn approved these changes Dec 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There are too many configuration in different workflows to keep track of them all :)

@huydhn
Copy link
Copy Markdown
Contributor

huydhn commented Dec 11, 2024 •
edited
Loading

cc @wdvr Here is an example of a change that will reduce CI cost from this month going forward

@atalman atalman added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 11, 2024
malfet
malfet approved these changes Dec 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malfet
Copy link
Copy Markdown
Contributor

malfet commented Dec 12, 2024

@pytorchbot merge -f "Trunk jobs are green for the most part"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Dec 12, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman atalman mentioned this pull request Dec 12, 2024
Closed
31 tasks
@anumol-baby anumol-baby mentioned this pull request Jun 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atalman @huydhn @malfet @pytorchmergebot