Reusable docker build workflow#142109
Closed
huydhn wants to merge 15 commits into
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142109
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0d1457c with merge base 45583a5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
reviewed
Dec 5, 2024
malfet
left a comment
Contributor
There was a problem hiding this comment.
This will introduce additional 7+ min 99% of times no-op step on linux.12x-large, wouldn't it?
Contributor
Author
Yeah, this approach needs to checkout PyTorch and check if the image exists. So, it we go with this, that's the cost to pay. |
Contributor
Author
|
Close in favor of pytorch/test-infra#6013 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make docker build workflow reusable so that others can call it and build the docker images before going into build jobs. Each workflow can then request which images it needs.
I'm also refactoring all workflows that have failures showing up in trunk when
.ci/dockeris updated.Fixes #141885
Testing
.ci/docker, for example: