Test docker build#141779
Closed
afrittoli wants to merge 8 commits into
Closed
Conversation
Magma is built for specific CUDA versions and stored in the ossci-linux bucket. Install it from there rather than the deprecated conda package. There are two places where magma is installed today: - install_conda.sh: extract the magma package in the same exact location where conda would install it, using a dedicated install_magma_conda.sh script - install_magma.sh: this script already uses a tarball. Use the new tarball instead of the tarball from the conda package. The format of the new tarball is compatible with the old one, so changes here are minimal:wq Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
atalman
reviewed
Nov 28, 2024
atalman
reviewed
Nov 28, 2024
atalman
reviewed
Nov 28, 2024
atalman
reviewed
Nov 28, 2024
atalman
reviewed
Nov 28, 2024
malfet
requested changes
Dec 3, 2024
malfet
left a comment
Contributor
There was a problem hiding this comment.
As it doesn't not reference any issue, it would be nice to provide a better description on what this PR is trying to achieve, as Test docker build is a big vague
malfet
reviewed
Dec 3, 2024
| - name: Calculate docker image | ||
| id: calculate-docker-image | ||
| uses: pytorch/test-infra/.github/actions/calculate-docker-image@main | ||
| uses: pytorch/test-infra/.github/actions/calculate-docker-image@test-calculate-docker-image |
Contributor
There was a problem hiding this comment.
This is a temp change, right?
Collaborator
Author
There was a problem hiding this comment.
Yes, just for testing purposes, not meant to be reviewed or merged 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_NUMBER
cc @seemethere @malfet @pytorch/pytorch-dev-infra