Fix cuda Manylinux 2_28 docker images PATH setting#139631
Closed
atalman wants to merge 1 commit intopytorch:mainfrom
Closed
Fix cuda Manylinux 2_28 docker images PATH setting#139631atalman wants to merge 1 commit intopytorch:mainfrom
atalman wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139631
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ebfabf4 with merge base 87404b6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
approved these changes
Nov 4, 2024
Contributor
malfet
left a comment
There was a problem hiding this comment.
LGTM, just curious why this is not the part of common/install_cuda.sh
huydhn
approved these changes
Nov 4, 2024
Contributor
Author
|
@pytorchmergebot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling Manywheel builds here: #138732
During the build I observe the failure with cuda jobs:
While correct sequence suppose to be:
Issue found to be missing PATH setting in 2_28 Docker file. This section exist in CentOS Docker file here:
https://github.com/pytorch/pytorch/blob/main/.ci/docker/manywheel/Dockerfile#L174-L175
(Please Note these Docker images are not used yet. The #138732 should enable using these images)