fix stride compare failed when size value equal to one in ForeachUtils.h#136426
Merged
kit1980 merged 1 commit intopytorch:release/2.5from Sep 25, 2024
Conversation
…s.h (pytorch#134546) When size value equal to one, tensor strides value need be skipped to compare. @ezyang Pull Request resolved: pytorch#134546 Approved by: https://github.com/janeyx99
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136426
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 440f2ed with merge base b7eb725 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
Contributor
|
this would be good to cherry pick yes |
Contributor
Author
Hi, Xu. Can you approve this pr to merge? |
Contributor
|
Someone from the release team will do the approval--they know that I've approved the original PR. |
kit1980
approved these changes
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s.h (#134546)
When size value equal to one, tensor strides value need be skipped to compare. @ezyang
Pull Request resolved: #134546 Approved by: https://github.com/janeyx99
Fixes #ISSUE_NUMBER